Re: [PATCH] d3dx11_43: Implement D3DX11GetImageInfoFromMemory

[Alistair Leslie-Hughes]

Hi Matteo,

I'll let you do this one.

Regards
Alistair.

On 6/8/21 6:12 am, Matteo Bruni wrote:
> On Fri, Jul 30, 2021 at 10:15 AM Alistair Leslie-Hughes
>  wrote:
> > Wine-bug: https://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.wine...
> > Signed-off-by: Alistair Leslie-Hughes
> >
> > dlls/d3dx11_42/Makefile.in    |   1 +
> >   dlls/d3dx11_43/Makefile.in    |   1 +
> >   dlls/d3dx11_43/main.c         |   9 -
> >   dlls/d3dx11_43/tests/d3dx11.c | 668 ++++++++++++++++++++++++++++++++++
> >   dlls/d3dx11_43/texture.c      | 176 +++++++++
> >   5 files changed, 846 insertions(+), 9 deletions(-)
>
> This looks like the perfect occasion for reworking the d3dx DLLs to
> avoid duplicating the whole thing, along the lines of
> https://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.wineh... and
> followups.
> Specifically I'd introduce a wined3dx DLL, then move the bulk of
> D3DX10GetImageInfoFromMemory() over there, keeping only the entrypoint
> (and any d3dx10-specific part, if they exist) in d3dx10. Then this
> patch would just introduce a wined3dx import to d3dx11 and the
> D3DX11GetImageInfoFromMemory() implementation will mostly call into
> wined3dx for the actual functionality. The tests should probably stay
> duplicated as in the current version of this patch. Finally, I'd wait
> and see what happens :P
>
> I'm sorry your patch has the honor of being the first to come after I
> made up my mind on the d3dx DLLs rework (and I do recall that this is
> the second time you get the lucky pick, after the forwards ->
> PARENTSRC transition from a few years back). I'd be glad if you want
> to try your hand at this, otherwise I'll do it myself, hopefully in
> the near future.