Jacek Caban jacek@codeweavers.com wrote:
Jacek Caban jacek@codeweavers.com wrote:
Those changes look mostly good, but we should probably not forward QI calls in BindProtocol_QueryInterface if the protocol doesn't support aggregation.
Also I don't mind tests from patch 1, but it would be probably easier to extend test_CreateBinding(). It would also make a testing the above comment trivial.
I've moved the tests to test_CreateBinding(), however making them pass requires more knowledge about interaction between the object and outer interface, I'd appreciate your help with it, I miss an outer reference count decrease somewhere, and couldn't figure this out yet.
Please test the attached patch with your application.
Thanks, as expected your patch fixes the regression, but the tests I've just sent crash.