Re: [PATCH] d3dx10: Add D3DXCpuOptimizations stub

[Matteo Bruni]

2016-07-20 7:34 GMT+02:00 Alistair Leslie-Hughes :
> On 20/07/16 15:04, Alex Henrie wrote:
> > -
> > - Copyright (C) 2007 David Adam
> > -
> > - Copyright (C) 2007 Tony Wasserka
> >
> > Did these people actually contribute anything to this patch?
>
> No, it was a copy from d3dx9math.h
> > Also, D3DX_CPU_OPTIMIZATION was already defined in d3dx9_30_main.c. I
> > would remove the old definition from d3dx9_30_main.c and make it
> > include d3dx10math.h instead.
>
> To remove the D3DX_CPU_OPTIMIZATION definition would be a separate patch
> in it's own right.  I will have to workout where it should be
> defined for d3dx9.  Including a dx10 header in dx9 seems like a bad idea.

Yeah. D3DX_CPU_OPTIMIZATION is not defined in "recent" d3dx9 headers
AFAICS so it's probably fine as it is.
> Best Regards
>  Alistair Leslie-Hughes