Re: [PATCH v2 2/4] gdi32: Avoid best fit chars when mapping unicode character to a glyph index.

[Dmitry Timoshkov]

Hi Huw,

thanks for the review.

Huw Davies  wrote:
> > --- a/dlls/gdi32/font.c
> > +++ b/dlls/gdi32/font.c
> > @@ -3223,7 +3223,7 @@ static DWORD CDECL font_GetGlyphIndices( PHYSDEV dev, const WCHAR *str, INT coun
> >                  if (str[i] >= 0xf020 && str[i] <= 0xf100) glyph = str[i] - 0xf000;
> >                  else if (str[i] < 0x100) glyph = str[i];
> >              }
> > -
> >        else if (WideCharToMultiByte( physdev->font->codepage, 0, &str[i], 1,
> > -
> >        else if (WideCharToMultiByte( physdev->font->codepage, WC_NO_BEST_FIT_CHARS, &str[i], 1,
> >                                      &ch, 1, NULL, &used ) && !used)
> >            glyph = (unsigned char)ch;
> >    }
>
> Hi Dmitry,
>
> I suspect this should wait until after 6.0.

I'm OK with deferring 2/4 and 3/4, however I hope that 1/4 (tests) and 4/4
(MS Sans Serif default glyph index) could be accepted, 4/4 doesn't depend
on previous patches in the series.
> What app does this fix?

The application that the patches fix is not publicly available.