Re: [PATCH 3/5] kernel32: Improve GetVolumeInformation filesystem flags

[GOUJON Alexandre]

On 08/31/2011 01:15 PM, Alexandre Julliard wrote:
> Alexandre Goujon  writes:
> >       if (fsname) lstrcpynW( fsname, ntfsW, fsname_len );
> >       if (filename_len) *filename_len = 255;
> > -
> >    if (flags) *flags = FILE_CASE_PRESERVED_NAMES;
> > -
> >    if (flags) *flags = FILE_NAMED_STREAMS | FILE_SUPPORTS_ENCRYPTION | FILE_SUPPORTS_OBJECT_IDS
> > -
> >            | FILE_SUPPORTS_REPARSE_POINTS | FILE_SUPPORTS_SPARSE_FILES | FILE_VOLUME_QUOTAS
> > -
> >            | FILE_FILE_COMPRESSION | FILE_PERSISTENT_ACLS | FILE_UNICODE_ON_DISK
> > -
> >            | FILE_CASE_PRESERVED_NAMES | FILE_CASE_SENSITIVE_SEARCH;
>
> I'm not sure it's a good idea to claim features we don't support. Do you
> have an app that needs this?

No, I don't.

When I worked on the patch, I made tests with several filesystems and 
noticed the values were wrong and variable across windows versions.
I asked here [1] what to do but no one answered me.
I also saw a FIXME comment in wine so I thought it was a good idea to 
fix these.

But I think you're right, an app may rely on what we claim, so you can 
reject this one.
---
[1] : http://www.winehq.org/pipermail/wine-devel/2011-August/091390.html