Re: [PATCH] mshtml/tests: Skip some tests if native XMLHTTP support is missing or disabled

[Jacek Caban]

On 08.01.2018 17:33, Alex Henrie wrote:
> 2018-01-08 6:47 GMT-07:00 Jacek Caban :
> > @@ -355,8 +358,12 @@ function test_text_node() {
> >  }
> >
> > function test_xhr() {
> > - if (typeof(XMLHttpRequest) != "object") {
> > -
> >    win_skip("XMLHTTPRequest is not available or disabled");
> > -
> >    return;
> > - }
> > - ok("XMLHttpRequest" in window, "XMLHttpRequest not found in window
> >
> > object\n");
> >
> > As far as I understand ok("XMLHttpRequest" in window) test works fine in
> > this configuration. It would be nice to keep the test before skipping the
> > rest.
>
> Internet Explorer 6, which was the browser that originally shipped
> with Windows XP, did not include XMLHttpRequest in the window object
> at all. If the intent is to support testing IE6 then skipping this
> test is correct.

I think the intent was to support IE7 with disabled XMLHttpRequest. I
assumed that IE6 will be skipped for another reason, but looking closer
I don't see it so yes, it may fail. Still, IE6 is not really an
interesting test case those days.

Thanks,
Jacek