On 12 August 2010 14:32, Vitaliy Margolen wine-devel@kievinfo.com wrote:
What are those magic numbers? Please use constants. If they are missing, add them to appropriate header file first.
They are the numbers passed to the InitAudio method from bug 22598. I've seen quite a few places where "magic" numbers are used in tests with no references. I thought it would be ok to start the test off this way.
What is the best way to resubmit for another round of review? To wine-patches again (try 3)? Or on wine-devel? Or something else.