On 22.06.2016 09:23, Austin English wrote:
Using WCHAR *
Previous try dropped without comment. Fixes https://bugs.winehq.org/show_bug.cgi?id=35892
-- -Austin GPG: 14FB D7EA A041 937B
0001-apphelp-add-SdbGetAppPatchDir-stub.patch
From 12b43f471b437309d80bf8625cdc4d518a225c72 Mon Sep 17 00:00:00 2001 From: Austin English austinenglish@gmail.com Date: Wed, 22 Jun 2016 02:17:19 -0500 Subject: [PATCH] apphelp: add SdbGetAppPatchDir stub
Signed-off-by: Austin English austinenglish@gmail.com
dlls/apphelp/apphelp.c | 5 +++++ dlls/apphelp/apphelp.spec | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/dlls/apphelp/apphelp.c b/dlls/apphelp/apphelp.c index 64dcd87..122642c 100644 --- a/dlls/apphelp/apphelp.c +++ b/dlls/apphelp/apphelp.c @@ -111,3 +111,8 @@ void WINAPI SdbCloseDatabase(PDB pdb) { FIXME("stub: %p\n", pdb); }
+void WINAPI SdbGetAppPatchDir(HSDB hsdb, WCHAR *path, DWORD size) +{
- FIXME("stub: %p %s %d\n", hsdb, debugstr_w(path), size);
Path is an output buffer, it does not make sense to use debugstr_w here. Also, MSDN says "If the function fails, this parameter is set to the empty string ("").". It would probably make sense to implement that, too.
+} diff --git a/dlls/apphelp/apphelp.spec b/dlls/apphelp/apphelp.spec index a658e5c..0119a48 100644 --- a/dlls/apphelp/apphelp.spec +++ b/dlls/apphelp/apphelp.spec @@ -49,7 +49,7 @@ @ stub SdbFreeFileInfo @ stub SdbFreeFlagInfo @ stub SdbGetAppCompatDataSize -@ stub SdbGetAppPatchDir +@ stdcall SdbGetAppPatchDir(ptr wstr long)
HSDB is a handle, so "long" is more appropriate.
@ stub SdbGetBinaryTagData @ stub SdbGetDatabaseID @ stub SdbGetDatabaseInformation -- 2.8.1