Re: [PATCH 1/3] cabinet/tests: Alter string declaration to include null terminator.

[Isira Seneviratne]

On Mon, Aug 19, 2019, 5:15 AM Chip Davis  wrote:
> August 18, 2019 5:51 PM, "Isira Seneviratne" <[e-mail]
> <[e-mail]%3E>> wrote:
>
> On Mon, Aug 19, 2019, 1:42 AM Alex Henrie  wrote:
> -
> - Copyright (C) 2019 Isira Seneviratne
> - static const char expected[12] = "Hello World!";
> - static const char expected[12] = {
>
> 'H','e','l','l','o','W','o','r','l','d','!','\0' };
>
> All you had to do was remove the number 12 and let the compiler
> determine the size of the array automatically. And you really
> shouldn't add your name at the top of the file unless you wrote a
> substantial chunk of the file.
>
> -Alex
>
> Okay, thanks.
> By the way, why would the tests fail?
>
> Because you left out the space character in the string.
>
> Chip

Thanks a lot!

Isira
>