On April 28, 2003 07:13 am, Dmitry Timoshkov wrote:
"Uwe Bonnes" bon@elektron.ikp.physik.tu-darmstadt.de wrote:
Dmitry> I've tested it before I sent the patch. Win2k just returns 0for Dmitry> both APIs without a crash.
Ah, that's fine!
Is your test perhaps integrable in our testsuite?
I don't think that every trivial change to the code requires a test suite.
This is one of my pet peeves.
Wine is imperfect. (What isn't!) To me it is frequently unclear whether a line of code is present because it is needed to emulate (possibly weird) Microsoft behaviour or because we want our code to be better than Microsoft's or because of brainfade on the part of the programmer or ...
That is why I like to see facts stated twice. Knowing which functions are supposed to handle null pointers is, to me, not trivial. (For example expand the question; is the function handling a null pointer or is it handling all segvs as Windows strlen does?)
Putting in a test would be even better than simply commenting that the behaviour is known for e.g. Win95; it might point out version differences and certainly will catch when we accidentally break the code.