Re: [PATCH] kernel32: Always start debugger on WinSta0.

[Zebediah Figura]

On 14/06/18 23:12, Alistair Leslie-Hughes wrote:
> From: Sebastian Lackner
> Signed-off-by: Alistair Leslie-Hughes
>
> dlls/kernel32/except.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/dlls/kernel32/except.c b/dlls/kernel32/except.c
> index de244fc..5f2166e 100644
> --- a/dlls/kernel32/except.c
> +++ b/dlls/kernel32/except.c
> @@ -304,6 +304,7 @@ static BOOL	start_debugger(PEXCEPTION_POINTERS epointers, HANDLE hEvent)
>      TRACE("Starting debugger %s\n", debugstr_a(cmdline));
>      memset(&startup, 0, sizeof(startup));
>      startup.cb = sizeof(startup);
> - startup.lpDesktop = (char *)"WinSta0";
> startup.dwFlags = STARTF_USESHOWWINDOW;
> startup.wShowWindow = SW_SHOWNORMAL;
> ret = CreateProcessA(NULL, cmdline, NULL, NULL, TRUE, 0, env, NULL, &startup, &info);

I guess one potential problem with this is bugs like 45369; perhaps it
would be better to suppress creating a window at all in such a case.