Re: [PATCH 4/5] wined3d: Set GL_UNPACK_ALIGNMENT to 1 when uploading surfaces from user memory.

[Henri Verbeet]

On 11 February 2015 at 10:46, Stefan Dösinger  wrote:
> Am 2015-02-10 um 22:05 schrieb Henri Verbeet:
> > What's a bit awkward about this is that if the pitch isn't a
> > multiple of the pixel byte width it's still not going to work. But
> > I guess this is the best we can do.
>
> Does this ever happen? D3D9 doesn't allow specifying a manual pitch,
> and ddraw has at most 4 byte pixels and enforces a pitch alignment of
> 4 according to our tests.
>
> Technically 24-bit RGB8 can have a misaligned pitch, but that isn't
> supported anywhere.

You're probably right. Perhaps we can just explicitly reject pitches
that aren't a multiple of the pixel byte width in
wined3d_surface_update_desc().