10 May
2006
10 May
'06
2:55 p.m.
On 5/10/06, H. Verbeet hverbeet@gmail.com wrote:
I think it would be best not to have USING_GLSL checks at several different places in the code. The function signatures are the same, so it wouldn't be that hard to just pass a pointer to the correct function.
True, it could be combined better in that function. I'll be on vacation for about a week, but I'll further clean that up when I get back.
FYI - I placed the USING_GLSL define in wined3d_private.h because it will also be needed in other placed in wined3d as well. At a minimum, we will also need it in drawprim.c - drawPrimitiveDrawStrided() where it sets the constants. I have a patch that does that currently, but it's too ugly to submit yet.