Re: [PATCH (try 2) 1/2] dpvoice/tests: Add GetCompressionTypes tests.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-01-15 um 22:38 schrieb Alex Henrie:
> It's not documented, but in practice Windows returns 7 elements
> plus their strings, which comes to DVCOMPRESSIONINFO[16] on English
> systems and a little less than DVCOMPRESSIONINFO[17] on non-English
> systems. DVCOMPRESSIONINFO[32] is more than enough, but the tests
> check for overflow just in case.

I think allocating this depending on the size returned by windows (+
some extra bytes to check the 0x23 filler) would be cleaner. I don't
think the size < sizeof(DVCOMPRESSIONINFO) * 32 has any value other
than verifying that the fixed size hasn't been exceeded.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUuUCaAAoJEN0/YqbEcdMwiP0P+wbVHDrq68QSx7OcI1imACyi
TGn0buTOETw+2lMg2fZ3D0wDqIzAuTm4HcDLiWhJbDyXDwZlPyA1ILnW7M1sArKQ
ztV2GZvhejMlW5zQsHBMhJs2zuu2PAWNX0LeHdVgIbBhbQXZ1G8eTSWYQElndvpR
Sv/QiNjLzXpiig8o4B+YMleBwktS9LW2ZsFkhiR1MfIQkVTy4JoiQ9eevfxpxdIj
GL/0heh0rVZ7cIncEzYp1S8xo+nWLrot4n6TSVwowONFLVynY/c4Rg37VEAzIO1j
6lZD4xjUyoOs2CiQfVu0NUV2ozheC3gE8ngLFfHAD8FpVHCkXrra/PTBiJ6VQx/4
PIe8xOXAC9/nyC/yF1VOwZhFq61Q6R/qercV7/JysbRa0Fw7Lrb66QDf6SqLG++M
DFx5o8YD6p9PWSdIT0VIeJgQIM7Y7pfnGeAeqLINvcAzjxWkcC783gqsuz4a+asq
VJh0kxlgrOcq6z7aOcYMx5edcIJ0V8qF5r4992VU4F7ILY1mGSmKMlF81i5cMLAK
RauIXdAlzSD9ZG8PvRnn+SBS1bnTwK3SfaZCowxq1FcRPbsjwpJFu/iOq0nI6tbw
OAnxtOaH/y961CaJ0t40YOUJO7Nw071oGArn7zJoiKjxj0aruY3CyOsfZ/u9D3tS
WJY5w+CpDRMccCQ94jfb
=OfyS
-----END PGP SIGNATURE-----