Re: [v4 PATCH 1/4] mfplat: Implement MFTRegister

[Alexandre Julliard]

Alistair Leslie-Hughes  writes:
> - if (cinput && input_types)
> - {
> -
>    size = cinput * sizeof(MFT_REGISTER_TYPE_INFO);
> -
>    types = HeapAlloc(GetProcessHeap(), 0, size);
> -
>    if (!types) goto err;
> -
> -
>    memcpy(types, input_types, size);
> -
> -
>    ret = RegSetValueExW(hclsid, inputtypesW, 0, REG_BINARY, (BYTE *)types, size);
> -
>    HeapFree(GetProcessHeap(), 0, types);

Why do you need to make a copy?
> - if (coutput && output_types)
> - {
> -
>    size = cinput * sizeof(MFT_REGISTER_TYPE_INFO);

I'm guessing you want coutput here.