John Birrell jb@cimlogic.com.au writes:
Note that the code I am questioning does not produce a compiler warning. The warning comes from code in the if-true path.
The compiler warning attracted my attention to code that if believe would be better as a #if.
No, using normal code is always better than #ifdefs. This way all the code gets compiled and checked for errors, plus you don't need to write autoconf magic for things that the compiler can do itself.