I am trying to get the tests to run before I submit a patch to shdocvw/webbrowser.c. My first attempts to get the tests to run.
This morning I did cd /home/davea/winebld/wine git fetch; git rebase origin # make sure you're up to date ./configure && make depend && make # rebuild the tree rm -rf ~/.wine # be sure to test in a clean WINEPREFIX
sudo cp /home/downloads/wine_gecko-1.0.0-x86.cab /usr/local/share/wine/gecko sh ../apps/winetricks winxp mkdir /home/davea/.wine/drive_c/windows/system32/gecko/1.0.0/wine_gecko /bin/echo -n "Wine Gecko 1.0.0"
/home/davea/.wine/drive_c/windows/system32/gec
ko/1.0.0/wine_gecko/VERSION cat /home/davea/.wine/drive_c/windows/system32/gecko/1.0.0/wine_gecko/VERSION make testclean make test
and it failed on an init_d3d8 call.
../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so visual.c && touch visual.ok err:wgl:opengl_error No OpenGL support compiled in. err:d3d_caps:WineD3D_CreateFakeGLContext Can't find a suitable iPixelFormat. err:d3d:InitAdapters Failed to get a gl context for default adapter err:d3d:WineDirect3DCreate Direct3D8 is not available without opengl visual.c:131: Tests skipped: could not create D3D8 visual.c:1312: Test failed: Could not initialize direct3d make[2]: *** [visual.ok] Error 1 make[2]: Leaving directory `/home/davea/winebld/wine/dlls/d3d8/tests' make[1]: *** [d3d8/tests/__test__] Error 2 make[1]: Leaving directory `/home/davea/winebld/wine/dlls' make: *** [dlls/__test__] Error 2
I note that d3d8/tests/visual.c does a win_skip() when the init_d3d3() fails. Why not a skip() ?
Changing the win_skip here to: if (!d3d8_ptr) { skip("could not create D3D8\n"); return NULL; }
enables the test to continue.
Which is right? win_skip or skip? Why?
This is on Ubuntu 9.10 (32bit), open-src drivers, ATI 4350 pci card.
Thanks in advance for any clues. DavidAnderson