Re: DOS packing patch (fix)

[Lionel Ulmer]

Hi all,

I am a bit worried by this patch : I looked at how "pshpack1.h" works, and
it uses the '#pragma pack(1)' method when compiling with GCC.
> +/* WARNING: one byte packed structs from here !! (i.e. not DWORD aligned) */
> +#include "pshpack1.h"
> -

And I wonder if this really works as with the latest versions of GCC (2.95.3
onwards AFAIK), '#pragma pack(1)' is ignored (at least on my self-compiled
GCC :-) ) and you need to use the '__attribute((__packed__))' construction
after each structure.

But well, I may say completely stupid things as otherwise a lot of bugs
would exist in Wine...

Lionel
           
PS: Merry Christmas all :-)