Re: [PATCH v2 resend 3/6] comctl32/listview: Send LVN_ODSTATECHANGED only for virtual lists.

[Zhiyi Zhang]

On 5/26/22 04:00, Angelo Haller wrote:
> From: Angelo Haller
>
> The LVN_ODSTATECHANGED notification should only be sent to lists
> that have LVS_OWNERDATA set.
> Signed-off-by: Angelo Haller
>
> dlls/comctl32/listview.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
> index 72ade724313..318df0a4093 100644
> --- a/dlls/comctl32/listview.c
> +++ b/dlls/comctl32/listview.c
> @@ -8946,6 +8946,7 @@ static VOID LISTVIEW_SetOwnerDataState(LISTVIEW_INFO *infoPtr, INT nFirst, INT n
>  {
>      NMLVODSTATECHANGE nmlv;
> - if (!(infoPtr->dwStyle & LVS_OWNERDATA)) return;

Make sense. It will be better if you can add a simple test before this patch and remove the todo_wines after the fix.
>  if (!item) return;
>
>  ZeroMemory(&nmlv, sizeof(nmlv));