On 6/3/21 5:43 PM, Zebediah Figura (she/her) wrote:
On 6/3/21 9:37 AM, Rémi Bernon wrote:
On 6/3/21 3:43 PM, Marvin wrote:
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=91742
Your paranoid android.
=== w864 (64 bit report) ===
Report validation errors: ntoskrnl.exe:ntoskrnl crashed (c0000374)
I think it's not even supposed to run on w864, as it says
ntoskrnl.c:349: Tests skipped: Failed to start service; probably your machine doesn't accept unsigned drivers.
But that crash seems genuine nonetheless, although I don't really understand how it happens... I'll have a look.
PATCH < 5 should be fine I guess.
FWIW, that's STATUS_HEAP_CORRUPTION.
Okay, and it seems to be crashing on:
ret = CertCloseStore(ctx->root_store, CERT_CLOSE_STORE_CHECK_FLAG);
in testsign_cleanup.
And it doesn't crash anymore if I add a ok(0, "...\n"); line before it.
I think there's some corruption lurking around, and the crash has nothing to do with the patch as the code it adds isn't even executed.