Re: [PATCH 3/5] winex11.drv: Only update drop effect if IDropTarget::DragOver returned S_OK

[Matteo Bruni]

2015-12-21 11:21 GMT+01:00 Piotr Caban :

diff --git a/dlls/winex11.drv/xdnd.c b/dlls/winex11.drv/xdnd.c
index d5881ad..841eaff 100644
--- a/dlls/winex11.drv/xdnd.c
+++ b/dlls/winex11.drv/xdnd.c
@@ -325,7 +325,7 @@ void X11DRV_XDND_PositionEvent( HWND hWnd,
XClientMessageEvent *event )
         if (dropTarget)
         {
             hr = IDropTarget_DragOver(dropTarget, MK_LBUTTON, pointl, &effect);
-            if (SUCCEEDED(hr))
+            if (hr != S_OK)
                 XDNDDropEffect = effect;
             else
                 WARN("IDropTarget_DragOver failed, error 0x%08X\n", hr);

Doesn't that do the opposite of what the patch title says?