I borked my reply in this with some wrong header. Hopefully, with a new
attempt, this gets put correctly.
October 23, 2019 3:09 PM, "Sveinar Søpler"cybermax@dexter.no wrote:
fixme:d3d12_device_CheckFeatureSupport: Unhandled feature 0x15.
That's D3D12_FEATURE_D3D12_OPTIONS3.
typedef struct D3D12_FEATURE_DATA_D3D12_OPTIONS3
{
BOOL CopyQueueTimestampQueriesSupported;
BOOL CastingFullyTypedFormatSupported;
D3D12_COMMAND_LIST_SUPPORT_FLAGS WriteBufferImmediateSupportFlags; /* VK_AMD_buffer_marker */
D3D12_VIEW_INSTANCING_TIER ViewInstancingTier; /* VK_KHR_multiview */
BOOL BarycentricsSupported; /* VK_NV_fragment_shader_barycentric, VK_AMD_shader_explicit_vertex_parameter */
} D3D12_FEATURE_DATA_D3D12_OPTIONS3;
The right thing to do, then, is to support this option--if only to say we don't really support anything in it. Does this patch fix it for you?
Chip
I will see if i can get this tested.
--
Sveinar
>
>> Ref. commit:
https://source.winehq.org/git/vkd3d.git/commitdiff/c002aee119b638d30eeb7cdc9...
>>
>> This patch breaks World of Warcraft (crash) with a
>>
>> fixme:d3d12_device_CheckFeatureSupport: Unhandled feature 0x15.
>>
>> Reverting this patch fixes it.
>>
>> WoW is still broken when zoning into Nazjatar tho ref.
>>
https://bugs.winehq.org/show_bug.cgi?id=47471 but that is a different
>> bug.
>>
>> Sveinar Søpler
>
>> On 16.10.2019 13:05, post at arntzen-software.no (Hans-Kristian
>> Arntzen) wrote:
>>> There appears to be a complete implementation of RS 1.1 already,
>>> so enable this feature.
>>>
>>> Signed-off-by: Hans-Kristian Arntzen <post at arntzen-software.no>
>>>
>>> ---
>>> libs/vkd3d/device.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/libs/vkd3d/device.c b/libs/vkd3d/device.c
>>> index 691a23a..d248726 100644
>>> --- a/libs/vkd3d/device.c
>>> +++ b/libs/vkd3d/device.c
>>> @@ -2720,8 +2720,7 @@ static HRESULT STDMETHODCALLTYPE d3d12_device_CheckFeatureSupport(ID3D12Device *
>>> return E_INVALIDARG;
>>> }
>>>
>>> - FIXME("Root signature version 1_1 not supported yet.\n");
>>> - data->HighestVersion = D3D_ROOT_SIGNATURE_VERSION_1_0;
>>> + data->HighestVersion = D3D_ROOT_SIGNATURE_VERSION_1_1;
>>>
>>> TRACE("Root signature version %#x.\n", data->HighestVersion);
>>> return S_OK;
>>> --
>>> 2.23.0
>>>
>>>
>>>
