Re: New uninstaller

[Dmitry Timoshkov]

"Jonathan Ernst"  wrote:
> Thanks for the hint. I found the allocation problem.

Here is another one:
> -
>                    int len = GetWindowTextLengthW(GetDlgItem(hwnd, IDC_FILTER));
> -
>                    if(len > 0)
> -
>                    {
> -
>                        sFilter = (WCHAR*)GlobalAlloc(GPTR, len + 1);
> -
>                        GetDlgItemTextW(hwnd, IDC_FILTER, sFilter, len + 1);

And this one:
> - /* Load MessageBox's strings */
> - LoadStringW(hInst, IDS_APPNAME, sAppName, sizeof(sAppName));
> - LoadStringW(hInst, IDS_ABOUTTITLE, sAboutTitle, sizeof(sAboutTitle));
> - LoadStringW(hInst, IDS_ABOUT, sAbout, sizeof(sAbout));
> - LoadStringW(hInst, IDS_REGISTRYKEYNOTAVAILABLE, sRegistryKeyNotAvailable, sizeof(sRegistryKeyNotAvailable));
> - LoadStringW(hInst, IDS_UNINSTALLFAILED, sUninstallFailed, sizeof(sUninstallFailed));

LoadStringW takes number of WCHARs, not bytes.

Everything else seems to be good enough.
> P.S. Do I really have to split this new uninstaller in different patches
> as nearly everything changed ?

It's up to Alexandre to decide, just send your work to wine-patches.