Re: [PATCH 3/8] kernel32: added CreateFileMappingNumaA

[Vijay Kiran Kamuju]

On Wed, May 8, 2019 at 9:54 AM Roman Stingler  wrote:
> Signed-off-by: Roman Stingler
>
> dlls/kernel32/kernel32.spec |  2 +-
>  dlls/kernel32/sync.c        | 10 ++++++++++
>  include/winbase.h           |  1 +
>  3 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec
> index 08a9a9cd9d..cc2283f886 100644
> --- a/dlls/kernel32/kernel32.spec
> +++ b/dlls/kernel32/kernel32.spec
> @@ -283,7 +283,7 @@
>  @ stdcall CreateFile2(wstr long long long ptr)
>  @ stdcall CreateFileA(str long long ptr long long long)
>  @ stdcall CreateFileMappingA(long ptr long long long str)
> -# @ stub CreateFileMappingNumaA
> +@ stdcall CreateFileMappingNumaA(long ptr long long long str long)
>  # @ stub CreateFileMappingNumaW
>  @ stdcall CreateFileMappingW(long ptr long long long wstr)
>  @ stdcall CreateFileW(wstr long long ptr long long long)
> diff --git a/dlls/kernel32/sync.c b/dlls/kernel32/sync.c
> index 9f5b614508..fd615575c4 100644
> --- a/dlls/kernel32/sync.c
> +++ b/dlls/kernel32/sync.c
> @@ -1346,6 +1346,16 @@ HANDLE WINAPI CreateFileMappingW( HANDLE file, LPSECURITY_ATTRIBUTES sa, DWORD p
>  }
>
> +/***********************************************************************
> -
> -
>         CreateFileMappingNumaA   (KERNEL32.@)
> - */
>
> +HANDLE WINAPI CreateFileMappingNumaA(HANDLE file,LPSECURITY_ATTRIBUTES sa,
> -
>    DWORD protect, DWORD size_high, DWORD size_low, LPCSTR name,DWORD preferred_numa_node)
>
> +{

Missing FIXME message.
> - SetLastError(ERROR_CALL_NOT_IMPLEMENTED);

why should not we return a dummy handle, instead of NULL?
> - return NULL;
>
> +}
> -
>
> /***********************************************************************
> -
>         OpenFileMappingA   (KERNEL32.@)
>
> */
> diff --git a/include/winbase.h b/include/winbase.h
> index 01fc4f5448..f1668de5c2 100644
> --- a/include/winbase.h
> +++ b/include/winbase.h
> @@ -1850,6 +1850,7 @@ WINBASEAPI HANDLE      WINAPI CreateFileW(LPCWSTR,DWORD,DWORD,LPSECURITY_ATTRIBU
>  WINBASEAPI HANDLE      WINAPI CreateFileMappingA(HANDLE,LPSECURITY_ATTRIBUTES,DWORD,DWORD,DWORD,LPCSTR);
>  WINBASEAPI HANDLE      WINAPI CreateFileMappingW(HANDLE,LPSECURITY_ATTRIBUTES,DWORD,DWORD,DWORD,LPCWSTR);
>  #define                       CreateFileMapping WINELIB_NAME_AW(CreateFileMapping)
> +WINBASEAPI HANDLE      WINAPI CreateFileMappingNumaA(HANDLE,LPSECURITY_ATTRIBUTES,DWORD,DWORD,DWORD,LPCSTR,DWORD);
>  WINBASEAPI HANDLE      WINAPI CreateIoCompletionPort(HANDLE,HANDLE,ULONG_PTR,DWORD);
>  WINBASEAPI HANDLE      WINAPI CreateJobObjectA(LPSECURITY_ATTRIBUTES,LPCSTR);
>  WINBASEAPI HANDLE      WINAPI CreateJobObjectW(LPSECURITY_ATTRIBUTES,LPCWSTR);
> --
> 2.21.0