Re: [PATCH] quartz: Add missing parameter.

[Matteo Bruni]

2017-10-07 15:55 GMT+02:00 Andrey Gusev :
> Signed-off-by: Andrey Gusev
>
> dlls/quartz/pin.c | 5 ++++-
>  dlls/quartz/pin.h | 5 ++++-
>  2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/quartz/pin.c b/dlls/quartz/pin.c
> index a2651fd49b..355d87d9d5 100644
> --- a/dlls/quartz/pin.c
> +++ b/dlls/quartz/pin.c
> @@ -218,7 +218,10 @@ static HRESULT PullPin_Init(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinI
>      return S_OK;
>  }
>
> -HRESULT PullPin_Construct(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinInfo, SAMPLEPROC_PULL pSampleProc, LPVOID pUserData, QUERYACCEPTPROC pQueryAccept, CLEANUPPROC pCleanUp, REQUESTPROC pCustomRequest, STOPPROCESSPROC pDone, LPCRITICAL_SECTION pCritSec, IPin ** ppPin)
> +HRESULT PullPin_Construct(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinInfo,
> -
>                      SAMPLEPROC_PULL pSampleProc, LPVOID pUserData, QUERYACCEPTPROC pQueryAccept,
> -
>                      CLEANUPPROC pCleanUp, REQUESTPROC pCustomRequest, STOPPROCESSPROC pDone,
> -
>                      LPCRITICAL_SECTION pCritSec, IPin ** ppPin)
>
> {
>      PullPin * pPinImpl;
>
> diff --git a/dlls/quartz/pin.h b/dlls/quartz/pin.h
> index 428fa6fe8e..2f29c929cf 100644
> --- a/dlls/quartz/pin.h
> +++ b/dlls/quartz/pin.h
> @@ -102,7 +102,10 @@ typedef struct PullPin
>  #define Req_Pause  3
>
> /*** Constructors ***/
> -HRESULT PullPin_Construct(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinInfo, SAMPLEPROC_PULL pSampleProc, LPVOID pUserData, QUERYACCEPTPROC pQueryAccept, CLEANUPPROC pCleanUp, STOPPROCESSPROC, REQUESTPROC pCustomRequest, LPCRITICAL_SECTION pCritSec, IPin ** ppPin);
> +HRESULT PullPin_Construct(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinInfo,
> -
>                      SAMPLEPROC_PULL pSampleProc, LPVOID pUserData, QUERYACCEPTPROC pQueryAccept,
> -
>                      CLEANUPPROC pCleanUp, REQUESTPROC pCustomRequest, STOPPROCESSPROC pDone,
> -
>                      LPCRITICAL_SECTION pCritSec, IPin ** ppPin);
>
> /**************************/
>  /*** Pin Implementation ***/
> --
> 2.13.6

Maybe I'm blind (I read this from the cell phone, so definitely
possible) but I don't see that you're adding any parameter, rather
swapping two arguments in the header only.
Just making sure that's what you meant to do.