Re: [PATCH] msxml3: Don't set properties directly

[Zebediah Figura]

On 27/02/18 13:07, Nikolay Sivov wrote:
> This might as well be correct, but I'll have to see myself.
>
> Valgrind results are reproducible, but test doesn't always crash, is
> that right?

It's not correct—as the tests show (specifically
test_get_ownerDocument), the properties should be shared. What probably
should be done instead is to refcount the properties, or move them to a
common structure. I looked into this at one point but wasn't sure enough
as to the architecture to try to fix it.