On Tue, 27 Jul 2021 at 03:28, Conor McCarthy cmccarthy@codeweavers.com wrote:
July 27, 2021 1:17 AM, "Henri Verbeet" hverbeet@gmail.com wrote:
Sure, but this would disassemble e.g. "dmov r0.xyzw, -cb0[0].zwxy" (fxc /dumpbin) as "dmov r0.xy, -cb0[0].zwxy" (vkd3d-compiler -b d3d-asm), unless we also add a corresponding change to shader_dump_dst_param().
Would you suggest including the shader_dump_dst_param() change in the same patch, or a separate patch in the same set?
It should be in the same patch as the shader_sm4_read_dst_param() change, but otherwise there are some options. E.g., one way to introduce the double support would be to first write a series introducing disassembler support (i.e., the dxbc.c and trace.c changes), and then a second series for SPIR-V generation. A single patch per instruction like this one for dmov also works though, as long as the dxbc.c and trace.c changes are trivial enough.