Jeremy White wrote:
I'll just mention that, assuming you are referring to this patch: http://cvs.winehq.org/patch.py?id=14198 it also causes a regression in Myst. Though I am not convinced the fault is in the patch, rather than the patch exposing some other problem.
Would you mind trying my experimental patch to see if it makes a difference? If it doesn't, could you also try the attached patch and see if that does?
The experimental patch did not help. This small yield patch seemed to help a little, but did not fix the problem. Without backing out the winmm patch, the sound and motion are both jerky, and eventually the intro Quicktime clip freezes up completely. It seemed to take longer to freeze up with the patch below than with the experimental patch.
After backing out the winmm patch, sound and motion are both smooth (though sound is not perfect, but that is a different issue). Tested with a 20041201 Wine version on RH7.3. There seem to be other problems now with a current CVS version on RH9, so I could not test there.
By the way, I will be away from my computer all this week. So any further testing will need to wait until next week sometime.
Cheers,
Jeremy
Index: dlls/ntdll/sync.c
RCS file: /home/wine/wine/dlls/ntdll/sync.c,v retrieving revision 1.42 diff -u -r1.42 sync.c --- dlls/ntdll/sync.c 14 Jan 2005 19:54:39 -0000 1.42 +++ dlls/ntdll/sync.c 12 Feb 2005 22:34:04 -0000 @@ -727,7 +727,9 @@ /* A test on Windows 2000 shows that Windows always yields during a wait, but a wait that is hit by an event gets a priority boost as well. This seems to model that behavior the closest. */ +#if 0 if (ret == WAIT_TIMEOUT) NtYieldExecution(); +#endif
return ret;}