Re: Shell32: Reimplement SHGetFolder functions

[Alexandre Julliard]

Juan Lang  writes:
> +static void loadShell32(void)
> +{
> - if (hShell32)
> - {
> -
>    if (pMalloc)
> -
>    {
> -
>        pMalloc->lpVtbl->Release(pMalloc);
> -
>        pMalloc = NULL;
> -
>    }
> -
>    /* until it's really unloaded: */
> -
>    while (FreeLibrary(hShell32))
> -
>        ;

I'm not sure what you are trying to do here, but this causes an
infinite loop on XP (and it probably should under Wine too, since the
test binary imports shell32). Also some tests fail on XP:

shellpath.c:433: Test failed: SHGetFolderPath returned 0x00000000, expected 0x80070002
shellpath.c:438: Test failed: SHGetFolderLocation returned 0x00000000, expected E_FAIL
shellpath.c:442: Test failed: SHGetSpecialFolderPath succeeded, expected failure
shellpath.c:447: Test failed: SHGetFolderLocation returned 0x00000000, expected E_FAIL