Re: mshtml: Implement IHTMLAnchorElement get/put target

[Jacek Caban]

On 2/18/11 9:54 AM, Alistair Leslie-Hughes wrote:
> static HRESULT WINAPI HTMLAnchorElement_get_target(IHTMLAnchorElement *iface, BSTR *p)
>   {
>       HTMLAnchorElement *This = impl_from_IHTMLAnchorElement(iface);
> - FIXME("(%p)->(%p)\n", This, p);
> - return E_NOTIMPL;
> - nsAString target_str;
> - nsresult nsres;
> - HRESULT hres = S_OK;
> -
> - TRACE("(%p)->(%p)\n", This, p);
> -
> - nsAString_Init(&target_str, NULL);
> - nsres = nsIDOMHTMLAnchorElement_GetTarget(This->nsanchor,&target_str);
> - if(NS_SUCCEEDED(nsres)) {
> -
>    const PRUnichar *target;
> -
> -
>    nsAString_GetData(&target_str,&target);
> -
>    *p = *target ? SysAllocString(target) : NULL;
> - }else {
> -
>    ERR("GetHref failed: %08x\n", nsres);
> -
>    hres = E_FAIL;
> - }
> -
> - nsAString_Finish(&target_str);
> - return hres;
> }

Please use use return_nsstr here.

Jacek