On Thu, Sep 1, 2011 at 7:52 AM, Octavian Voicu octavian.voicu@gmail.com wrote:
2011/9/1 Dan Kegel dank@kegel.com:
This patch found a bug in my scripts - it failed to grep the patch for sender and subject - but it looks like there might be something wrong with the patch itself, it doesn't apply here.
The patch uses dos line endings, that's why it doesn't apply.
That's it, thanks. (I had seen them, but thought patch tools were smart enough to ignore 'em; I guess patch does if the whole patch is in CRLF format, but in this case, the preamble wasn't.)
I just checked, and none of our .c, .h, or .po files have embedded CR's. I guess it would be ok to strip trailing CR's on incoming patches, I'll do that.
But there's something even fishier about http://source.winehq.org/patches/data/78249 -- it ends in a block of NUL characters. What's up with that? hexdump -C shows ... 00001560 20 0d 0a 20 23 3a 20 77 69 6e 68 6c 70 33 32 2e | .. #: winhlp32.| 00001570 72 63 3a 36 34 0d 0a 20 23 2c 20 66 75 7a 7a 79 |rc:64.. #, fuzzy| 00001580 0d 0a 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00001590 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| * 00001d80 00 00 0a 0a |....|
- Dan