Am 13.01.2022 um 19:35 schrieb Gabriel Ivăncescu gabrielopcode@gmail.com:
If you think some tests are redundant or too overkill, I'll happily remove them (or, if you have suggestions to add even more...).
Nah, I think they are OK as is. ddraw is a pain, it won't get any easier, I'm just trying to make sure I don't sign off on something I don't understand myself
Also I'll fix the dumb window2 leak, sorry. Let me know if there's anything else though, before I resend (but probably will do tomorrow).
Nothing so far at least for patches 1 to 3. I can't rule out something won't pop into my mind after another re-read, but right now, with the window2 leak fixed, you have my signed-off-by.