Re: [PATCH v3 1/2] scrrun: Extract code to new helper function build_path.

[Nikolay Sivov]

On 11/24/21 1:23 AM, Robert Wilhelm wrote:
> Signed-off-by: Robert Wilhelm
>
> dlls/scrrun/filesystem.c | 109 +++++++++++++++++++++------------------
>  1 file changed, 58 insertions(+), 51 deletions(-)
>
> diff --git a/dlls/scrrun/filesystem.c b/dlls/scrrun/filesystem.c
> index 68ef1786af9..e55615eb4da 100644
> --- a/dlls/scrrun/filesystem.c
> +++ b/dlls/scrrun/filesystem.c
> @@ -223,6 +223,63 @@ static BSTR get_full_path(BSTR path, const WIN32_FIND_DATAW *data)
>      return SysAllocString(buffW);
>  }
>
> +static HRESULT WINAPI build_path( BSTR Path, BSTR Name, BSTR *Result)
> +{
> - BSTR ret;
> -
> - TRACE("%s %s %p\n", debugstr_w(Path), debugstr_w(Name), Result);
> -
> - if (!Result) return E_POINTER;

You don't need to specify calling convention explicitly for this. Also,
please remove TRACE, and move Result check back to BuildPath - you won't
need it for 2/2.