Alexandre Julliard julliard@winehq.org wrote:
Aren't these supposed to be defined inside the activeds typelib instead?
PSDK defines IADsADSystemInfo and ADSystemInfo in iads.h which is a generated header (supposedly from iads.idl, where I put these definitions as well). On the other hand activeds.tlb contains much more interfaces and definitions than iads.h does, so I'd guess that activeds.tlb is generated from an .idl that includes most of active directory related .idl files.
Is there anything else that prevents accepting these two patches? Or perhaps add some underscores to typedefs to make the patches more appealing? It looks like they are no longer frowned upon these days? :)
I still think they should be in the typelib. If you look at the interface registrations with your second patch they don't match the Windows ones.
Thanks for the review, still it would be more helpful to get this kind of information a bit faster, without taking a week, and another query.
Which interface registration do you have in mind? As far as I can see ADSystemInfo registration matches what I see in Windows, do I miss something else?