Re: [PATCH 1/6] ole32/tests: Simplify implicit MTA tests.

[Huw Davies]

On Sun, Mar 25, 2018 at 12:33:57PM -0500, Zebediah Figura wrote:
> Signed-off-by: Zebediah Figura
>
> dlls/ole32/tests/compobj.c | 229 ++++++++++-----------------------------------
>  1 file changed, 47 insertions(+), 182 deletions(-)
>
> diff --git a/dlls/ole32/tests/compobj.c b/dlls/ole32/tests/compobj.c
> index f1e0134..da4223b 100644
> --- a/dlls/ole32/tests/compobj.c
> +++ b/dlls/ole32/tests/compobj.c
> +static DWORD CALLBACK implicit_mta_proc(void *param)
> +{
> - IComThreadingInfo *threading_info;
> - ULONG_PTR token;
> - IUnknown *unk;
> - CLSID clsid;

clsid is unused at this point.  I know you'll use it later on.  If I wasn't
going to ask for other changes, I'd ignore it.
> - HRESULT hr;
> -
> - test_apt_type(APTTYPE_MTA, APTTYPEQUALIFIER_IMPLICIT_MTA, TRUE, TRUE);
> -
> - hr = CoCreateInstance(&CLSID_InternetZoneManager, NULL, CLSCTX_INPROC_SERVER, &IID_IUnknown, (void **)&unk);
> - ok_ole_success(hr, "CoCreateInstance");
> - IUnknown_Release(unk);
> -
> - hr = CoGetClassObject(&CLSID_InternetZoneManager, CLSCTX_INPROC_SERVER, NULL, &IID_IUnknown, (void **)&unk);
> - ok_ole_success(hr, "CoGetClassObject");
> - IUnknown_Release(unk);
> -
> - hr = CoGetObjectContext(&IID_IComThreadingInfo, (void **)&threading_info);
> - ok_ole_success(hr, "CoGetObjectContext");
> - IComThreadingInfo_Release(threading_info);
> -
> - hr = CoGetContextToken(&token);
> - ok_ole_success(hr, "CoGetContextToken");
> -
> - return 0;
>
> +}