On 8/29/07, Juan Lang juan.lang@gmail.com wrote:
That doesn't make it better, it's not thread-safe. Pass them as parameters to decodeRIFF.
Ahh, I see. Yes, fixed.
I still say a symbolic constant is better, or at the least, a comment. A test case that shows that it's needed is even better.
http://msdn2.microsoft.com/en-us/library/ms648061.aspx
dwVersion [in] Specifies the version number of the icon or cursor format for the resource bits pointed to by the pbIconBits parameter. This parameter can be 0x00030000.
and if you pop into the wine/dlls/user32 dir and do a grep 0x00030000 * you'll see I'm not the first to follow the documentation. It's cryptic, but hey, it's Microsoft.
Trent