On 02.09.2016 05:35, Sebastian Lackner wrote:
On 31.08.2016 12:49, Akihiro Sagawa wrote:
On Tue, 30 Aug 2016 21:48:49 +0200, Sebastian Lackner wrote:
This patch broke various user32 tests in virtual desktop mode, for example:
$ (cd dlls/user32/tests/; make broadcast.ok) ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so broadcast && touch broadcast.ok
(snip)
make: *** [Makefile:197: broadcast.ok] Fehler 17
Could you please take a look?
Sure. I'll take a look. Thanks for report.
Akihiro Sagawa
Just to let you know, in the meantime I have tracked down what is causing the test failure (but I am not yet sure how to fix it). Starting with your change, we are also creating IME windows for "OleMainThreadWndClass" windows. In this particular case, the watch_desktop_folders thread created by explorer.exe is causing the trouble. The thread does not have any message loop which is blocking broadcast messages.
Should we filter this case in imm32.needs_ime_window?
Actually we should probably skip creation for all windows with HWND_MESSAGE parent. Nevertheless, I will leave a fix to someone more familiar. ;)
Regards, Sebastian