2014/1/8 Dmitry Timoshkov dmitry@baikal.ru:
+void test_SHGetPathFromIDListA(void) +{
- BOOL ret;
- char pszPath[MAX_PATH];
- ret = SHGetPathFromIDListA(NULL, pszPath);
- ok(!ret, "SHGetPathFromIDListA should fail.\n");
+}
Thank you for reviewing my patch.
- the test should be 'static'.
- who is supposed to call this test?
Sorry, I've missed them.
- it would be ineteresting to see whether the tested API should set
an error code or somehow indicate a reason of the failure.
You're right. I'll check GetLastError() in my patch.
BTW, is putting such code in string.c a good idea?