Re: [PATCH v5 2/5] jscript: Pass null jsval to builtin functions instead of the global host.

[Jinoh Kang]

On 12/14/21 06:12, Jacek Caban wrote:
> Hi Gabriel,
>
> The series will obviously need to wait for the code freeze. I took a look and didn't catch problems with patch 1 (although I will have another look when the time comes).
>
> On 12/10/21 10:52 PM, Gabriel Ivăncescu wrote:
> > else
> > -        vthis = jsval_disp(lookup_global_host(ctx));
> > +        vthis = jsval_null();
>
> This looks suspicious, doesn't it break the assumption that 'this' is an object in ES3?

Yes, and it does not conform to ES5 strict mode either, where `this` should be undefined.
> Thanks,
>
> Jacek