Re: [PATCH] msvcrt:msvcrt_get_flags: Fix bug 51846 - fopen(..., "wx")

[Piotr Caban]

Hi Ted,

On 10/7/21 7:48 PM, Ted Lyngmo wrote:
> I noticed that the tests I added for this patch failed to pass TestBot. 
> This is my first patch so I may have missed something.
>
> I ran the test suite locally like this:
>
> WINETEST_DEBUG=1 ./wine ./dlls/msvcrt/tests/msvcrt_test.exe file
>
> When running the test suite with the Wine version that is included in 
> Fedora 34, it fails as expected:
>
> file.c:123: Test failed: overwrote existing file with mode wx
> file.c:133: Test failed: overwrote existing file with mode w+x
>
> With my patch, my test cases passes locally but TestBot says:
>
> file.c:119: Test failed: creating file with mode wx failed
> file.c:129: Test failed: creating file with mode w+x failed
>
> Any advice?

The tests are failing on Windows. I've tried running them on fully 
updated Windows 10 and it also fails there. Is the 'x' format only 
supported in ucrtbase.dll (you have added the tests for msvcrt.dll)?

Thanks,
Piotr