January 7, 2022 6:19 AM, "Giovanni Mascellani" gmascellani@codeweavers.com wrote:
Hi,
I think that this patch should be squashed with 1/8. The idea is that the code should be "clean" at all times, even between the patches of a single patch set, and my understanding is that being clean includes having a "hlsl_" prefix for all the symbols in hlsl.h (this also applies to 3/8).
Also, I think that renaming the function and moving it to another file are changes simple enough that they can be merged in the same patch. But if you really prefer doing that in two patches, I'd first change the name and then move.
Giovanni.
Okay! I have been told that's preferable to move something and change it on different patches, but maybe that is when the changes are more than just changing the name.