Re: [PATCH] rpcrt4: make sure we do not have *data allocated on error (Coverity)

[Michael Stefaniuc]

On 05/20/2015 04:50 PM, Marcus Meissner wrote:
> 713688 Resource leak
> callers expect *data only allocated when success is returned.
>
> dlls/rpcrt4/rpc_transport.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c
> index 34f434d..4080b14 100644
> --- a/dlls/rpcrt4/rpc_transport.c
> +++ b/dlls/rpcrt4/rpc_transport.c
> @@ -2359,6 +2359,7 @@ static RPC_STATUS rpcrt4_http_read_http_packet(HINTERNET request, RpcHttpAsyncDa
>      if (!RPCRT4_IsValidHttpPacket(hdr, *data, data_len))
>      {
>          ERR("invalid http packet\n");
> -
>    if (*data) HeapFree(GetProcessHeap(), 0, *data);

Marcus, you don't need the if not NULL check as HeapFree(NULL) is a no-op.

bye
    michael