Re: [PATCH] comctl32/taskdialog: Use parentheses around & operator

[Nikolay Sivov]

On 09/15/2018 05:32 PM, Fabian Maurer wrote:
> Signed-off-by: Fabian Maurer
>
> dlls/comctl32/taskdialog.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/comctl32/taskdialog.c b/dlls/comctl32/taskdialog.c
> index f69fa6aaa3..1d91e1d55d 100644
> --- a/dlls/comctl32/taskdialog.c
> +++ b/dlls/comctl32/taskdialog.c
> @@ -118,7 +118,7 @@ static unsigned int taskdialog_get_reference_rect(const TASKDIALOGCONFIG *taskco
>       info.cbSize = sizeof(info);
>       GetMonitorInfoW(monitor, &info);
> - if (taskconfig->dwFlags & TDF_POSITION_RELATIVE_TO_WINDOW && taskconfig->hwndParent)
> - if ((taskconfig->dwFlags & TDF_POSITION_RELATIVE_TO_WINDOW) && taskconfig->hwndParent)
>      GetWindowRect(taskconfig->hwndParent, ret);
>  else
>      *ret = info.rcWork;

Unless it fixes some warning you get, I don't see a point in changing that.