On Thu, Mar 4, 2010 at 11:20 AM, Eric Ho ericho921@gmail.com wrote:
Hi Guys, I'm a UCLA student working with Dan Kegel on cmd. This attached patch adds tests for the following buffer overflows, and passes on winetestbot. Fixes http://bugs.winehq.org/show_bug.cgi?id=21344. Overflows fixed:
- overflow due to long path name (unchecked memcpy,strcpy to thisDir)
- overflow due to long file name (unchecked strcpy into stemofsearch)
- overflow due to concatenating thisDir into stemofsearch (strcat)
- added early breaks when getFullPathName returns an error
- fixed incorrect errorlevel code (needs to be 9023 and it was 9009)
Howdy Eric,
Patches should be sent to wine-patches@winehq.org. wine-devel is for questions/discussion, or for feedback on patches.