Re: [PATCH 3/4] gdiplus: Implement unfilled mode for arrow caps.

[Nikolay Sivov]

On 5/14/2018 7:17 PM, Vincent Povirk wrote:
> > - points[0].X = 0.0;
> > - points[0].Y = 0.0;
> > - points[1].X = -cap->width / 2.0;
> > - points[1].Y = -cap->height;
> > - points[2].X = 0.0;
> > - points[2].Y = -cap->height - cap->middle_inset;
> > - points[3].X = cap->width / 2.0;
> > - points[3].Y = -cap->height;
> > - if (cap->cap.fill)
> > - {
> > -
> >    memcpy(cap->cap.pathdata.Types, types_filled, sizeof(types_filled));
> > -
> >    cap->cap.pathdata.Count = 4;
> > -
> >    points[0].X = -cap->width / 2.0;
> > -
> >    points[0].Y = -cap->height;
> > -
> >    points[1].X = 0.0;
> > -
> >    points[1].Y = 0.0;
> > -
> >    points[2].X = cap->width / 2.0;
> > -
> >    points[2].Y = -cap->height;
> > -
> >    points[3].X = 0.0;
> > -
> >    points[3].Y = -cap->height - cap->middle_inset;
>
> Why does this reorder the points in the filled case?

No particular reason, only to bring two cases closer. If you mean I
should have used this order in a first place, sure, I can do that in 2/4.