On Thursday 26 May 2005 13:18, Stefan Dösinger wrote:
Any further suggestions? If not, I'll modify the other shflrds and send a patch to wine-patches ;-)
Looks good to me.
Two style things:
First, I would move the psfParent and rpidl variable declarations into the then-branch of the if statement, since this is the only place they are used. But this is of course personal preference.
Second, please use the -pu flags when generating the diff. This makes the diffs more robust and more easily readable for humans.
Bye,