On Thu, 23 Jul 2020 at 21:11, Andrew Eikum aeikum@codeweavers.com wrote:
On Thu, Jul 23, 2020 at 11:38:04AM -0500, Zebediah Figura wrote:
On 7/23/20 10:21 AM, Andrew Eikum wrote:
This needs a configure.ac change, right? That might be why the testbot failed. FWIW with that change, it passes on my machine and the testbot:
https://testbot.winehq.org/JobDetails.pl?Key=75977Yes, I usually omit them because Alexandre reruns it anyway (and my local version has never quite matched). The testbot should be able to figure out that it needs to rerun make_makefiles, but the logic may be broken...
My understanding was you should include the configure.ac changes, since that file isn't generated, but not the configure/config.h.in/etc changes, because those are generated.
The "makefile list" in configure.ac is generated by tools/make_makefiles.