Nikolay Sivov nsivov@codeweavers.com wrote:
Please use existing function for this.
I considered that, however existing test_selectSingleNode() is cluttered by failure cases, and finally doesn't test anything useful. Using it as a place for new tests would add even more mess. I'd prefer to make new tests for multiple namespaces a separate test, which could be extended with new tests if needed.
Just append it there, and remove whatever you think is broken with existing tests. Having separate functions for every occasion is worse.
There's nothing broken in exising tests, they are just a cluttered mess. Adding new tests to the end of a mess is not very nice IMO. What's wrong with having separate bodies for very different tests?