Re: [PATCH 1/2] wininet/test: Add InternetGetSecurityInfoByURLW test

[Jacek Caban]

On 05.01.2018 02:02, Wei Xie wrote:
> -
> -
>    res = pInternetGetSecurityInfoByURLA(url, NULL, NULL);
> -
>    ok_(__FILE__,__LINE__)(!res, "InternetGetSecurityInfoByURLA failed: %u\n", GetLastError());

Please test GetLastError() in this case (I think that setting last error
is missing in your second patch). Also it would be interesting to know
if both arguments are required or one of them may be NULL. Please add a
test that passes NULL for only one of them.

Also, if this test will crash without the second patch, the series
should be reordered. All tests must pass between each separate commit.
In this case I think that sending tests and a fix in one patch would be
even better.

Thanks,

Jacek