Re: [PATCH 02/10] winex11: Add stub Vulkan ICD

[Roderick Colenbrander]

On Wed, Nov 1, 2017 at 3:04 AM, Józef Kucia  wrote:
> > +void* WINAPI X11DRV_vk_icdGetInstanceProcAddr(VkInstance instance, const char* pName)
>
> Please use consistent style for pointers. I think that "void * WINAPI"
> and "const char *pName" would be preferred.
> > +{
> > - FIXME("stub: %p, %s\n", instance, pName ? pName : "NULL");
>
> Wouldn't it be better to use debugstr_a() or something similar? Please
> also note that some strings in Vulkan API can be UTF-8 according to
> the spec.

I could replace some of those yes. I have been out of the loop of Wine
for a bit, but do we have anything which can print UTF-8 yet? A lot of
the strings indeed are, but so far just use the ASCII subset.